Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move artifact graph creation into Rust #4860

Open
jtran opened this issue Dec 23, 2024 · 0 comments
Open

Move artifact graph creation into Rust #4860

jtran opened this issue Dec 23, 2024 · 0 comments
Assignees

Comments

@jtran
Copy link
Collaborator

jtran commented Dec 23, 2024

The artifact graph is a graph representing the output of a KCL program, where nodes of the graph are objects like planes, paths, extrusions, etc. and edges of the graph are the relationships between them, like this extrusion is a linear extrude of that path, and this path is on that plane. Currently, the artifact graph is generated in TS by intercepting the requests and responses of engine calls made by the KCL interpreter.

There are a few motivations for moving this to Rust.

  1. It would continue to work without communicating with the engine (AKA mock execution) during sketch mode
  2. We believe it would be easier to maintain in Rust

Drawbacks

  1. More data will need to cross the WASM boundary. Contrast this with how it is now where TS code derives the information from the engine messages, which have to cross the boundary anyway in order to use the WebSocket.
@jtran jtran self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant