-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release instructions for Windows #60
Comments
This is a first pass at one off powershell script. I'm still not sure how it fits into the rest of the release process but wanted to at least documented what I had. There is still a shortcoming where the enviroment path will be duplicated if this script is run multiple times, but the bones are there. cc'ing @jessfraz for awareness since she pointed this out to me on slack.
|
Here's an updated version that includes a check with system env variables so that paths don't become duplicated
|
In the releases there are install instructions for various platforms, but the windows instructions are wrong as they use linux paths e.g.
windows/amd64
Changes probably need to be made to cli/basic.mk
Looking at our cli install action might help as it works with a Windows runner, though it still uses bash, perhaps instructions should use powershell. Also adding the cli to %PATH% would be different outside of a github action runner.
The text was updated successfully, but these errors were encountered: