Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookahead bias #2

Open
tamas-pap opened this issue Jul 25, 2022 · 1 comment
Open

Lookahead bias #2

tamas-pap opened this issue Jul 25, 2022 · 1 comment

Comments

@tamas-pap
Copy link

Hey. Thanks for the descriptive notebook. Good job!

The problem is, that you have a lookahead bias in the trade method, which will make in significantly more likely that your buy/sell signals will generate profit. In reality, that will not be the case.

@vr-marco
Copy link
Contributor

How? The look-ahead bias is not in the trade function, which properly uses the test set (out of sample).
It is actually in the fact that the selection of the cointegrated pairs has been done beforehand on the whole dataset (training+test) instead that just on the training set, so very likely there is a survivorship bias for the selected pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants