-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting extension features also enables all available features #938
Labels
framework
This is relevant to the framework
Comments
19 tasks
19 tasks
One could introduce a new function
... and would need to adjust all usages of |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a lot of samples we do something like this:
auto &requested_extension_features = gpu.request_extension_features<VkPhysicalDeviceSomeExtensionFeaturesKHR>(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SOME_EXTENSION_FEATURES_KHR); requested_extension_features.someFeature = VK_TRUE;
But the call to
gpu.request_extension_features
already sets all supported features to true by callingvkGetPhysicalDeviceFeatures2KHR
, which makes the second line (enabling a feature) superfluous.This doesn't do any harm, but it might confuse people trying to write or debug samples.
The text was updated successfully, but these errors were encountered: