Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtomicStorageOps is missing dependency on AtomicStorage #473

Open
bashbaug opened this issue Jan 16, 2025 · 0 comments
Open

AtomicStorageOps is missing dependency on AtomicStorage #473

bashbaug opened this issue Jan 16, 2025 · 0 comments

Comments

@bashbaug
Copy link
Contributor

According to the SPV_KHR_shader_atomic_counter_ops extension, AtomicStorageOps should depend on / implicitly declare AtomicStorage, but this dependency isn't described in the grammar file:

{
"enumerant" : "AtomicStorageOps",
"value" : 4445,
"extensions" : [ "SPV_KHR_shader_atomic_counter_ops" ],
"version" : "None"
},

Since the extension spec refers to the dependency in several places, I think the grammar file should be updated and not the extension text, but either could be modified to fix the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant