Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inlay hints in VSCode #2196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable inlay hints in VSCode #2196

wants to merge 2 commits into from

Conversation

kevinbarabash
Copy link
Contributor

Summary:

Inlay hints can be useful at see the types for things without having to hover over everything. They can also be useful in understand what args are being passed as what params especially when the args are literals.

This PR enables all of the inlay hints in our .vscode/settings.json. In order to see the inlay hints developers must press and hold Ctrl-Opt at the same time otherwise they're not visible.

If developers want to customize this behaviour they can do so in their User settings.json for VSCode.

Issue: None

Test plan:

  • open a .ts file in VSCode
  • press Ctrl-Opt
  • see all of the inlay hints
Screen Shot 2024-03-12 at 10 23 07 AM

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: 7c400b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 13, 2024

npm Snapshot: NOT Published

🤕 Oh noes!! We couldn't find any changesets in this PR (052945f). As a result, we did not publish an npm snapshot for you.

@kevinbarabash kevinbarabash requested a review from a team March 13, 2024 19:02
Copy link
Contributor

github-actions bot commented Mar 13, 2024

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-jwzhwafwja.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 0
Tests with visual changes 0
Total stories 405
Inherited (not captured) snapshots [TurboSnap] 319
Tests on the build 319

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Size Change: 0 B

Total Size: 93.1 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 3.78 kB
packages/wonder-blocks-banner/dist/es/index.js 1.53 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.71 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 4.28 kB
packages/wonder-blocks-cell/dist/es/index.js 2.24 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.3 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.7 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 12.3 kB
packages/wonder-blocks-form/dist/es/index.js 5.32 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.21 kB
packages/wonder-blocks-icon/dist/es/index.js 1.06 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.88 kB
packages/wonder-blocks-link/dist/es/index.js 2.54 kB
packages/wonder-blocks-modal/dist/es/index.js 5.52 kB
packages/wonder-blocks-pill/dist/es/index.js 1.27 kB
packages/wonder-blocks-popover/dist/es/index.js 4.86 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.55 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.1 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 697 B
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-tokens/dist/es/index.js 867 B
packages/wonder-blocks-toolbar/dist/es/index.js 857 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #2196 (7c400b0) into main (d70af06) will increase coverage by 0.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
+ Coverage   94.29%   95.18%   +0.88%     
==========================================
  Files         247      247              
  Lines       28576    28576              
  Branches     2330     2341      +11     
==========================================
+ Hits        26946    27199     +253     
+ Misses       1630     1377     -253     

see 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70af06...7c400b0. Read the comment docs.

@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/cold-cars-peel.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team March 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants