Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add IBM i RPG ile, Control Language ile, DDS, Uim and CMD langages? #248

Open
ibmiiste opened this issue Sep 27, 2023 · 13 comments

Comments

@ibmiiste
Copy link

Hi,
I am a developper on that langages, could you add them to your plugin.

RPG ile
https://www.ibm.com/docs/en/i/7.5?topic=rpg-ile-reference

Control langage
https://www.ibm.com/docs/en/i/7.5?topic=programming-control-language

DDS and UIM languages
https://public.dhe.ibm.com/systems/power/docs/systemi/v6r1/en_US/sc415715.pdf

CMD language
https://www.ibm.com/docs/en/i/7.5?topic=commands-cl-command-definition-statements
Regards,
Olivier.

@KevinBatdorf
Copy link
Owner

I can, but they might take some time to get merged in. I need to find a suitable textmate file for each, then submit it to the library upstream. Do you use an extension in your editor to get the proper highlighting?

I maybe found the RPG one. Is this it? https://github.com/NielsLiisberg/RPG-for-SublimeText

But I coulnd't find the others with a quick search.

@ibmiiste
Copy link
Author

ibmiiste commented Sep 28, 2023

Hi,

There is IBMi Languages for Vscode used by Code for IBM i.

Features:
Syntax highlighting for RPG III and RPG/400 - H,F,E,L,I,C,O specs
Syntax highlighting for Control Language (CL)
Syntax highlighting for Command Definition (CMD)
Syntax highlighting for UIM Panel Group (PNLGRP)
Syntax highlighting for DDS files - physical, logical, display, printer, and ICF
Syntax highlighting for Machine Interface (MI)
Syntax highlighting for RPGLE fixed - H,F,D,I,C,O,P specs
Syntax highlighting for RPGLE free
Syntax highlighting for embedded SQL in SQLRPG and SQLRPGLE
Support for a mix of RPGLE free and fixed format
Support for binder language
Support for DB2 SQL keywords in embedded SQL

Is this suits you?

Regards,

Olivier.

@ibmiiste
Copy link
Author

ibmiiste commented Oct 3, 2023

Hi,

Do you need some more information?

Regards,

Olivier.

@KevinBatdorf
Copy link
Owner

Sorry, just been busy I guess. These files actually look ok. Would it be possible for you to provide an idiomatic code sample for each one?

When I add a grammar upstream they have these guidelines to follow, which include adding a sample

In /packages/shiki/samples/, add a code sample file .sample for your language. A sample should include a variety of language syntaxes and succinctly capture the idiosyncrasy of a language. Format requirements:

@ibmiiste
Copy link
Author

ibmiiste commented Oct 4, 2023

No problem, I can do that.

@ibmiiste
Copy link
Author

ibmiiste commented Oct 6, 2023

Hi,

Here is the first one bnd.sample.

bnd.sample.txt

@KevinBatdorf
Copy link
Owner

I found this list actually. I'll use these: https://github.com/barrettotte/vscode-ibmi-languages/tree/master/tests/general

@KevinBatdorf
Copy link
Owner

Opened a PR here: shikijs/shiki#526

@ibmiiste
Copy link
Author

I found this list actually. I'll use these: https://github.com/barrettotte/vscode-ibmi-languages/tree/master/tests/general

Hi,

Yes you can use them.

do not hesite to ask me some question if needed.

Regards,

Olivier.

@ibmiiste
Copy link
Author

ibmiiste commented Oct 19, 2023

Hi,

Do you have any news? I saw an issue on the pull request, do you need some help from my skill field?

Regards,

@KevinBatdorf
Copy link
Owner

It's a matter of waiting for them to merge it and tag a release. You could comment on the PR to show your interest in getting it merged. Not sure if it would help though.

If there isnt activity for awhile I may fork the project and add them, but that gets a bit complicated to maintain the fork. It's an option though.

@ibmiiste
Copy link
Author

ibmiiste commented Mar 4, 2024

Hi,

there ie an answer from shikijs/shiki#526, it seems that they changed the process to add a request.

Regards,

Olivier.

@KevinBatdorf
Copy link
Owner

Thanks for following up. Yeah I saw they moved to v1.0 and I want to update it. It's not going to be a trivial task though and given the way Gutenberg is structured, I may have to include both v1.0 and the the last sub 1.0 version to avoid invalidating everyone's code.

I also want to give a good upgrade path, but that will involve writing a complex tool to process all the blocks in the browser (the renderer requires webassembly).

I plan to do all this "soon" but I don't want to commit to a timeline because I can't predict my schedule (I work full time as well). It's near the front of my todo list though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants