Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Info needed regarding #5 UITableView Cells with Enum #1

Open
hamada147 opened this issue Nov 29, 2018 · 3 comments
Open

More Info needed regarding #5 UITableView Cells with Enum #1

hamada147 opened this issue Nov 29, 2018 · 3 comments

Comments

@hamada147
Copy link

Hello @KarimEbrahemAbdelaziz ,
Please add to the notes that the XNib file that contain the cell must have that cell identifier with the same value as one we want to add in the enum. Or don't enter a value for the identifier in the first place and it will take the value of the file name by default.

@KarimEbrahemAbdelaziz
Copy link
Owner

Hello @KarimEbrahemAbdelaziz ,
Please add to the notes that the XNib file that contain the cell must have that cell identifier with the same value as one we want to add in the enum. Or don't enter a value for the identifier in the first place and it will take the value of the file name by default.

Hey Ahmed,
Thanks for your interested in the repo and 🥇 issue :D
I already did what you said.
"what you only need to set cell reuse identifier in xib file as it's class name"
do you think it's not clear enough?!

@hamada147
Copy link
Author

Hello @KarimEbrahemAbdelaziz ,
I'm sorry to inform you that it was not clear to me but after testing and playing with it. I thought I would ask you to added this little info to the repo.

@KarimEbrahemAbdelaziz
Copy link
Owner

Hello @KarimEbrahemAbdelaziz ,
I'm sorry to inform you that it was not clear to me but after testing and playing with it. I thought I would ask you to added this little info to the repo.

Sure I could add it. just tell me the exact phrase you want to add and i will for sure :)
Or even better why didn't fork the repo and make a pull request with the changes? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants