out_as_local_url called on a non-local URL

[nadavkav]

While upgrading to latest version (2021080400), I got the following error message (CLI)
!!! Coding error detected, it must be fixed by a programmer: out_as_local_url called on a non-local URL !!!

It seems to be referring to settings.php
$returnurl = $PAGE->url->out_as_local_url(false);

I am using Moodle 3.9.8

[bcaballero]

Do you have any recommended versions to avoid this error? It is a blocker upgrading from 0.4.2 2021020300 to 1.0.1 2021080400.

[Kemmotar83]

Hi,

since the "returning URL" is always the same, I have temporarily "solved" the error replacing that row with the following one (with the "hardcoded URL").

$returnurl = new moodle_url('/admin/settings.php?section=qtypesettingshortmath');

It works and this could fix the error.

Giorgio

[nadavkav]

Here is what I did, and found useful:

// Link to configuration manager page.
    if (empty($CFG->upgraderunning)) {
        $returnurl = $PAGE->url->out_as_local_url(false);
    } else {
        $returnurl = '';
    }

If this make sense to you, I can send a PR.

[mrkskwsnck]

Hi,

since the "returning URL" is always the same, I have temporarily "solved" the error replacing that row with the following one (with the "hardcoded URL").

$returnurl = new moodle_url('/admin/settings.php?section=qtypesettingshortmath');

It works and this could fix the error.

Giorgio

@Kemmotar83 Your temp fix works 4 me. Thankx

[brendanheywood]

@andstor could we please have a review of this trivial fix:

#70