-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Combo timeout is not enforced for small values #748
Comments
That's because python on an MCU is slow (and KMK isn't super optimized). Can't be easily "fixed" as such. |
A sea-picro, which is an RP2040 based MCU using the pi micro footprint. |
I have a suspicion that the slowness can be sidestepped somehow. Likely a tough issue, but keypad library is interrupt driven, so it shouldn't be impossible. |
That's not wrong, and in the long run I intended to look into basing timeouts on the |
I do not know about the internals of KMK. But if a timer was to be started on the first key press of a potential combo, and was to register an event on timeout, then that could be used to discriminate between a roll and a combo. |
Describe the bug
I've set my combos to trigger if key presses occur within 45ms. The combo gets triggered on longer delays.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The combo should not activate, and individual key presses should be output.
Debug output
Additional context
The keys of the combos are MT keys. I would expect the combo and MT delays to be in parallel.
In my example the keys pressed are 't' and 'e', and output
p
instead ofte
. The delay between the key presses is 85ms, almost twice as long as the 45ms timeout configured, and yet the chord gets activated.My layout: xs18.txt
The text was updated successfully, but these errors were encountered: