-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skvh filter_cluster_snapshot filters out everything for ['*'] as filter. #313
Closed
piosok
wants to merge
4
commits into
K2InformaticsGmbH:master
from
piosok:308_skvh_filter_cluster_snapshot_start
Closed
skvh filter_cluster_snapshot filters out everything for ['*'] as filter. #313
piosok
wants to merge
4
commits into
K2InformaticsGmbH:master
from
piosok:308_skvh_filter_cluster_snapshot_start
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'*' is not interpreted as wildcard becuse only symbols in list are considered wildcards. added clause hasWild to interpret '*' as wildcard too.
piosok
changed the title
#308
#308 skvh filter_cluster_snapshot filters out everything for ['*'] as filter.
Jan 16, 2020
c-bik
requested changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide a failing unit test first?
c-bik
changed the title
#308 skvh filter_cluster_snapshot filters out everything for ['*'] as filter.
skvh filter_cluster_snapshot filters out everything for ['*'] as filter.
Jan 16, 2020
… compilation for ['*'] case
c-bik
requested changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #308
'*'
is not interpreted as wildcard becuse only symbols in list are considered wildcards.added clause hasWild to interpret
'*'
as wildcard too.