Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skvh filter_cluster_snapshot filters out everything for ['*'] as filter. #313

Closed
wants to merge 4 commits into from
Closed

skvh filter_cluster_snapshot filters out everything for ['*'] as filter. #313

wants to merge 4 commits into from

Conversation

piosok
Copy link
Contributor

@piosok piosok commented Jan 16, 2020 •
edited by c-bik

fixes #308

'*' is not interpreted as wildcard becuse only symbols in list are considered wildcards.
added clause hasWild to interpret '*' as wildcard too.

@piosok
K2InformaticsGmbH#308
c202cd0 
'*' is not interpreted as wildcard becuse only symbols in list are considered wildcards.
added clause hasWild to interpret '*' as wildcard too.
@piosok piosok changed the title #308 #308 skvh filter_cluster_snapshot filters out everything for ['*'] as filter. Jan 16, 2020
@coveralls
Copy link

coveralls commented Jan 16, 2020 •
edited

Coverage Status

Coverage increased (+0.06%) to 48.263% when pulling 117b7aa on piosok:308_skvh_filter_cluster_snapshot_start into 6bec45d on K2InformaticsGmbH:master.

@c-bik c-bik self-requested a review January 16, 2020 12:05
c-bik
c-bik requested changes Jan 16, 2020
View reviewed changes
Copy link
Member

@c-bik c-bik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a failing unit test first?

@c-bik c-bik self-assigned this Jan 16, 2020
@c-bik c-bik changed the title #308 skvh filter_cluster_snapshot filters out everything for ['*'] as filter. skvh filter_cluster_snapshot filters out everything for ['*'] as filter. Jan 16, 2020
@c-bik c-bik mentioned this pull request Jan 16, 2020
Open
c-bik
c-bik requested changes Jan 17, 2020
View reviewed changes
src/imem_snap.erl Outdated Show resolved Hide resolved
src/imem_snap.erl Outdated Show resolved Hide resolved
src/imem_snap.erl Outdated Show resolved Hide resolved
src/imem_snap.erl Show resolved Hide resolved
@piosok piosok requested a review from c-bik January 17, 2020 15:26
@c-bik
Copy link
Member

c-bik commented Feb 10, 2020

@piosok your solution was on the right track it just needed some cosmetics improvement which I did here #318.

Thanks for your contribution 👍

@c-bik c-bik closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bik c-bik Awaiting requested review from c-bik

Assignees

@c-bik c-bik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

009137 '*' on skvh for ClusterFilterSnapshot does not work
3 participants
@piosok @coveralls @c-bik