Bump minimal supported julia version to 1.6 #1901
Conversation
In JuliaStats#1900, dependency on Roots.jl is being added, which only supports julia 1.6+
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
- Coverage 85.99% 85.90% -0.09%
==========================================
Files 144 144
Lines 8666 8657 -9
==========================================
- Hits 7452 7437 -15
- Misses 1214 1220 +6 ☔ View full report in Codecov by Sentry. |
LebedevRI
force-pushed
the
julia-1.6
branch
from
519493b
to
3d9225a
Compare
I *think* this is a false-positive: ``` Running tests: 1 ambiguities found. To get a list, set `broken = false`. Ambiguity JuliaStats#1 frule(::ChainRulesCore.RuleConfig, args...) in ChainRulesCore at /home/runner/.julia/packages/ChainRulesCore/I1EbV/src/rules.jl:64 frule(::Any, ::typeof(Distributions.logpdf), d::Distributions.Uniform, x::Real) in Distributions.DistributionsChainRulesCoreExt at /home/runner/work/Distributions.jl/Distributions.jl/ext/DistributionsChainRulesCoreExt/univariate/continuous/uniform.jl:1 Possible fix, define frule(::ChainRulesCore.RuleConfig, ::typeof(Distributions.logpdf), ::Distributions.Uniform, ::Real) Aqua: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78 Expression: iszero(num_ambiguities) Stacktrace: [1] _test_ambiguities(packages::Vector{Base.PkgId}; broken::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78 [2] _test_ambiguities @ ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:69 [inlined] [3] test_ambiguities(packages::Module; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28 [4] test_ambiguities(packages::Module) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28 [5] macro expansion @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:19 [inlined] [6] macro expansion @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined] [7] top-level scope @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:9 ```
LebedevRI
force-pushed
the
julia-1.6
branch
from
3d9225a
to
6a2ef5a
Compare
|
I'm not a fan of updating Julia compat entries as long as there is no compelling reason to do so (e.g., if it involves unreasonable additional maintenance burden or limits development). That's not the case currently in Distributions in general, so IMO the change should be kept in #1900 as the only reason might be to change it if we decide to add a dependency on Roots. |
|
I don't disagree. The point here was that adding a dependency on IOW i don't know how to deal with remaining test failures there. (Why are only two julia versions being tested in CI but many more versions |
In #1900, dependency on Roots.jl is being added, which only supports julia 1.6+
This seems to result in new failures, so i'm doing this as a separate step.