Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow plots for long sequences in UI #364

Open
1 of 8 tasks
cncastillo opened this issue Apr 8, 2024 · 0 comments
Open
1 of 8 tasks

Slow plots for long sequences in UI #364

cncastillo opened this issue Apr 8, 2024 · 0 comments
Labels
bug Something isn't working KomaUI

Comments

@cncastillo
Copy link
Member

cncastillo commented Apr 8, 2024

What happened?

As some people have commented, the plots can become quite slow for long sequences.

I enabled a few new options in plot_seq:

  • gl=false: That changes the scatter plot backend, making it faster, but you will not be able to output an svg with vector graphics, the lines will be rasterized (this one I also added to plot_signal). Moreover, when slider=true the lines using the scattergl backend will dissapear. The phantom plot uses it as default (scatter3d).
  • max_rf_samples=100: This already existed, but now it is 100 by default
  • false: Shows adc points as markers

I also optimized get_samples so there are fewer samples to plot.

The same can be applied to the base plotting function and the default values in the UI

Environment

OS x86_64-linux-gnu
Julia 1.10.2
KomaMRIPlots 0.8.1
KomaMRIFiles 0.8.1
KomaMRICore 0.8.1
KomaMRIBase 0.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working KomaUI
Projects
None yet
Development

No branches or pull requests

1 participant