Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move piracy to GFT.jl #27

Open
rafaqz opened this issue Nov 5, 2024 · 3 comments
Open

Move piracy to GFT.jl #27

rafaqz opened this issue Nov 5, 2024 · 3 comments

Comments

@rafaqz
Copy link
Member

rafaqz commented Nov 5, 2024

All of these are type piracy, but would probably be fine in GeoFormatTypes.jl proper

Base.pairs(p::GFT.ProjJSON) = pairs(p.val)
GFT.ProjJSON(input::Dict{Symbol,<:Any}) = GFT.ProjJSON(todict(input))
Parquet2.default_determine_type(::Vector{GFT.WellKnownBinary{GFT.Geom,Vector{UInt8}}}) = Parquet2.ParqByteArray()
Base.length(A::GFT.WellKnownBinary) = Base.length(A.val)
Base.write(io::IOBuffer, A::GFT.WellKnownBinary{GFT.Geom,Vector{UInt8}}) = Base.write(io, A.val)

@evetion
Copy link
Member

evetion commented Dec 20, 2024

🏴‍☠️

@evetion
Copy link
Member

evetion commented Dec 20, 2024

FWIW I think the Base ones should move, I should investigate the constructor (what's todict), and the Parquet2 one is bad, but probably best to be here?

There exist similar questions for the methods above this snippet, which define StructTypes for GFT stuff.

@rafaqz
Copy link
Member Author

rafaqz commented Dec 21, 2024

Yes Base methods should be in GFT.

Then StructTupes could be in a GFT extension?

Parquet2 can stay here. GFT can't have that extension its too high level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants