-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package registration, name, interaction with rest of ecosystem #33
Comments
I think that if we name it LikelihoodFunctions.jl, it should not lie in the JuliaGaussianProcesses organisation. But in JuliaStats or something, that would make harder for us to contribute... The link structure in GLM is pretty nice |
Hmm yeah, that does look helpful. They've probably got more dependencies than would be ideal for us, but possibly we could try and sort that out? It's not obvious to me that their "likelihoods" are quite what we're after. Regarding naming the package, what about something like "ConditionalDistributions.jl", in recognition of the fact that we are, indeed, defining a load of conditional distributions and functions on them? I don't feel too strongly about the name though. |
It's getting a bit awkward to develop SparseGPs without this being registered, so I'd definitely be in favour of registering it |
That's my inclination -- we should just register it as-is with the current name and everything, and deprecate it later if that becomes necessary for some reason. If we come up with a better solution later, we can always create another package elsewhere. |
Registration PR open: JuliaRegistries/General#40456 If anyone continues to have a strong objection to this, we can cancel it again, but my preference would be for this to get registered and for us to crack on with development. |
Did we not agree to rename it to likelihood functions?
On Tuesday, August 3, 2021, willtebbutt ***@***.***> wrote:
Registration PR open: JuliaRegistries/General#40456
If anyone continues to have a strong objection to this, we can cancel it
again, but my preference would be for this to get registered and for us to
crack on with development.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.<
|
Ah, sorry, I think I understood the discussion differently from you. I thought we were going to rename LikelihoodFunctions if we joined forced with others. Either way, we can always swap out rebrand to LikelihoodFunctions at a later date if we do generalise. |
@st-- @willtebbutt I think this issue can now be closed? |
Yup, I'm happy to close. |
"GPLikelihoods.jl" is currently not a registered package. This makes it more difficult than necessary for users of this package such as https://github.com/rossviljoen/SparseGPs.jl. It is overdue to register the code inside this repo.
Update: GLM.jl defines link functions in https://github.com/JuliaStats/GLM.jl/blob/master/src/glmtools.jl
The text was updated successfully, but these errors were encountered: