Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package registration, name, interaction with rest of ecosystem #33

Closed
st-- opened this issue Jul 22, 2021 · 10 comments
Closed

Package registration, name, interaction with rest of ecosystem #33

st-- opened this issue Jul 22, 2021 · 10 comments

Comments

@st--
Copy link
Member

st-- commented Jul 22, 2021

"GPLikelihoods.jl" is currently not a registered package. This makes it more difficult than necessary for users of this package such as https://github.com/rossviljoen/SparseGPs.jl. It is overdue to register the code inside this repo.

@theogf
Copy link
Member

theogf commented Jul 22, 2021

I think that if we name it LikelihoodFunctions.jl, it should not lie in the JuliaGaussianProcesses organisation. But in JuliaStats or something, that would make harder for us to contribute...

The link structure in GLM is pretty nice

@willtebbutt
Copy link
Member

Hmm yeah, that does look helpful. They've probably got more dependencies than would be ideal for us, but possibly we could try and sort that out?

It's not obvious to me that their "likelihoods" are quite what we're after.

Regarding naming the package, what about something like "ConditionalDistributions.jl", in recognition of the fact that we are, indeed, defining a load of conditional distributions and functions on them? I don't feel too strongly about the name though.

@willtebbutt
Copy link
Member

@st-- @theogf one and a bit weeks on, what are your thoughts on this problem?

My feeling is that the links look quite nice, and probably we want to try and use them, but that we probably still need our likelihoods. My inclination is therefore to go ahead and register this package.

What are your thoughts @st-- @theogf ?

@rossviljoen
Copy link
Contributor

It's getting a bit awkward to develop SparseGPs without this being registered, so I'd definitely be in favour of registering it

@willtebbutt
Copy link
Member

willtebbutt commented Aug 3, 2021

That's my inclination -- we should just register it as-is with the current name and everything, and deprecate it later if that becomes necessary for some reason. If we come up with a better solution later, we can always create another package elsewhere.

@willtebbutt
Copy link
Member

Registration PR open: JuliaRegistries/General#40456

If anyone continues to have a strong objection to this, we can cancel it again, but my preference would be for this to get registered and for us to crack on with development.

@st--
Copy link
Member Author

st-- commented Aug 3, 2021 via email

@willtebbutt
Copy link
Member

Did we not agree to rename it to likelihood functions?

Ah, sorry, I think I understood the discussion differently from you. I thought we were going to rename LikelihoodFunctions if we joined forced with others.

Either way, we can always swap out rebrand to LikelihoodFunctions at a later date if we do generalise.

@theogf
Copy link
Member

theogf commented Sep 3, 2021

@st-- @willtebbutt I think this issue can now be closed?

@willtebbutt
Copy link
Member

Yup, I'm happy to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants