Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for environments where "invert" is problematic #19

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 3, 2024

This adds the keep_invert option to PlainTextPrinter and HTMLPrinter.
This may fix JuliaDocs/Documenter.jl#2487 with a few CSS modifications.

This is a somewhat breaking change, but I don't think "invert" is used that much.

This adds the `keep_invert` option to `PlainTextPrinter` and `HTMLPrinter`.
@kimikage kimikage marked this pull request as ready for review April 5, 2024 05:08
@kimikage
Copy link
Collaborator Author

kimikage commented Apr 5, 2024

The only modifications needed in Documenter.jl should be to update the [compat] of ANSIColoredPrinters and to define CSS for sgr-39 and sgr-49.
Since this package is currently v0.0.1, the next version (v0.1.0?) will necessarily be considered a breaking change.

@mortenpi Is this appropriate for the Documenter.jl side?

@kimikage kimikage merged commit f404ed1 into JuliaDocs:main Apr 22, 2024
14 checks passed
@kimikage kimikage deleted the keep_invert branch April 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of ANSI foreground/background inversion is incorrect
1 participant