Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing Tables.allocatecolumn in vcat #3432

Open
bkamins opened this issue Mar 23, 2024 · 0 comments
Open

Consider removing Tables.allocatecolumn in vcat #3432

bkamins opened this issue Mar 23, 2024 · 0 comments
Labels
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Mar 23, 2024

Related https://julialang.zulipchat.com/#narrow/stream/274208-helpdesk-.28published.29/topic/vcat.20dataframes.20with.20pooledarrays

Currently we use Tables.allocatecolumn as it is safe. E.g. currently we have an issue with PooledArrays.jl JuliaData/PooledArrays.jl#88 which current design handles correctly.

Probably it would be better to improve over Tables.allocatecolumn (which looks only at element type and disregards container type)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant