fix unique() behaviour, add unique!() #358
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft of a solution for #357, this PR renamesunique(::CategoricalArray)
touniquelevels(::CategoricalArray)
as it better reflects what this method doesThis PR restores the
Base.unique()
behavior -- makesunique(x::CategoricalArray)
return the categorical array of the same type asx
and containing the unique values ofx
in the order of their first appearance.The internal implementation of
unique()
is cleaned up and optimized a bit (avoid intermediate array sorting, generalize toAbstractCategoricalArray
).The PR also adds
Base.unique!(x::CategoricalArray)
.The newunique()
is not yet covered by unit tests. I'll do that if the overall approach would be considered ok.If you need the old
unique(x::CategoricalArray)
behavior, useunwrap.(unique(x))
.As this is backward-incompatible change, the new minor version would be required.
Needs to be rebased once #359 lands.Fixes #357, #129.