-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase plot in marginplot does not show dashed line at -180 degrees. #771
Comments
baggepinnen
added a commit
that referenced
this issue
Feb 1, 2023
phase guides should be shown at pm 180 deg, not at 0. fixes #771
baggepinnen
added a commit
that referenced
this issue
Feb 1, 2023
phase guides should be shown at pm 180 deg, not at 0. fixes #771
Hello and thanks for the report! I think that the problem here comes from the fact that the system is believed to have infinite phase margin when considering only the frequencies over which the plot is drawn, the gain curve never crosses 1. If the gain of the system is increased, you get the phase guide at -180. marginplot(10y2,
xticks=exp10.(-2:0.5:4),
) There are thus two problems here
Providing a better frequency vector also resolves the problem julia> w = exp10.(LinRange(-2, 2, 200));
julia> marginplot(y2, w,
xticks=exp10.(-2:0.5:4),
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version: ControlSystems v1.5.1
the output of the code above is as follows:
In the magnitude graph, a dashed line at 0 is shown. In the phase graph, a dashed line at -180 degrees is not shown.
The text was updated successfully, but these errors were encountered: