Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: get to 100% code coverage for ArrayInterface.jl #102

Open
DilumAluthge opened this issue Jan 4, 2021 · 11 comments
Open

Goal: get to 100% code coverage for ArrayInterface.jl #102

DilumAluthge opened this issue Jan 4, 2021 · 11 comments

Comments

@DilumAluthge
Copy link
Member

For context, here is the current code coverage:

Codecov

cc: @chriselrod

@chriselrod
Copy link
Collaborator

What's the best way to test the parses depending on CUDA?

@DilumAluthge
Copy link
Member Author

We can use Buildkite, which provides GPU CI to packages in the Julia GPU ecosystem.

I can take care of that.

@DilumAluthge
Copy link
Member Author

@chriselrod Do you have admin permissions on this repo?

@chriselrod
Copy link
Collaborator

chriselrod commented Jan 4, 2021

Yes. Or at least, I can merge. What needs to happen?

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jan 4, 2021

Kind of complicated. We need:

  1. Merge some YAML files into this repo. This only requires merge permission on this repo.
  2. Add some webhooks to this repo. This requires admin privileges on this repo.
  3. Install the BuildKite GitHub app on this repo. This requires a SciML organization owner. This step has already been completed.
  4. The Buildkite config. I can do this part.

@ChrisRackauckas
Copy link
Member

I'll give you temporary ownership in SciML for it.

@DilumAluthge
Copy link
Member Author

Thanks. I'll ping you on GitHub (or Slack, if Slack comes back up) when it's done.

@DilumAluthge
Copy link
Member Author

Actually I don't need temporary ownership. The GitHub app is already done.

Either @chriselrod or I needs temporary admin-ship on this repo only.

@Tokazama
Copy link
Member

Tokazama commented Jan 4, 2021

Just chiming in to reassure that I will keep adding tests for code I've contributed to.

@DilumAluthge
Copy link
Member Author

Webhooks are added. @ChrisRackauckas Can you de-owner me when you get a chance?

I'll make a PR in a bit to add the BuildKite YAML to this repo, and then we should be all set.

@ChrisRackauckas
Copy link
Member

De-owned. I'll keep you and @chriselrod in the team for this repo though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants