From ba42e6f21a178cdaa74493ebefc1558c6ef417f2 Mon Sep 17 00:00:00 2001
From: Jose Esparza <28990958+pebeto@users.noreply.github.com>
Date: Thu, 17 Aug 2023 09:03:32 -0500
Subject: [PATCH] Adding service accesor method and fixing instance order

---
 src/base.jl   | 7 +++++++
 src/types.jl  | 2 +-
 test/base.jl  | 6 +++++-
 test/types.jl | 2 +-
 4 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/base.jl b/src/base.jl
index dab922e..4f77974 100644
--- a/src/base.jl
+++ b/src/base.jl
@@ -30,3 +30,10 @@ function save(logger::MLFlowLogger, mach::Machine)
     logartifact(logger.service, run, fname, io)
     updaterun(logger.service, run, "FINISHED")
 end
+
+"""
+    service(logger::MLFlowLogger)
+
+Returns the MLFlow service of a logger.
+"""
+service(logger::MLFlowLogger) = logger.service
diff --git a/src/types.jl b/src/types.jl
index a74d79e..8548d45 100644
--- a/src/types.jl
+++ b/src/types.jl
@@ -36,5 +36,5 @@ function MLFlowLogger(baseuri; experiment_name="MLJ experiment",
     if ~healthcheck(service)
         error("It seems that the MLFlow server is not running. For more information, see https://mlflow.org/docs/latest/quickstart.html")
     end
-    MLFlowLogger(service, experiment_name, artifact_location, verbosity)
+    MLFlowLogger(service, 1, experiment_name, artifact_location)
 end
diff --git a/test/base.jl b/test/base.jl
index 33353c3..d1be5e1 100644
--- a/test/base.jl
+++ b/test/base.jl
@@ -1,4 +1,4 @@
-@testset "logging functions" begin
+@testset verbose = true "base" begin
     logger = MLFlowLogger("http://localhost:5000";
         experiment_name="MLJFlow tests",
         artifact_location="./mlj-test")
@@ -35,6 +35,10 @@
         @test loaded_mach.model isa ProbabilisticPipeline
     end
 
+    @testset "accesor methods" begin
+        @test MLJFlow.service(logger) isa MLFlow
+    end
+
     experiment = getorcreateexperiment(logger.service, logger.experiment_name)
     deleteexperiment(logger.service, experiment)
 end
diff --git a/test/types.jl b/test/types.jl
index 94db7aa..814a04b 100644
--- a/test/types.jl
+++ b/test/types.jl
@@ -1,4 +1,4 @@
-@testset "logger type" begin
+@testset "types" begin
     logger = MLFlowLogger("http://localhost:5000")
 
     @test typeof(logger) == MLFlowLogger