Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various type hints #78

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix various type hints #78

merged 1 commit into from
Apr 30, 2024

Conversation

michaelosthege
Copy link
Member

I got annoyed by mypy erros in other places, so why not fix the cause.

  • Simplifies some imports.
  • Adds and fixes type hints in various signatures.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@lhelleckes lhelleckes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good job!

@lhelleckes lhelleckes merged commit 57773f2 into master Apr 30, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
@michaelosthege michaelosthege deleted the type-fixes branch April 30, 2024 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants