Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orion3 degradations #277

Open
traumschule opened this issue Dec 12, 2023 · 0 comments
Open

orion3 degradations #277

traumschule opened this issue Dec 12, 2023 · 0 comments

Comments

@traumschule
Copy link
Contributor

The current state of orion shines a bad light on the project and makes the ecosystem less inclusive. This is because basic known commands don't work anymore, two containers always fail due to wrong default db settings without instructions and version conflicts inside containers, for example:

orion_graphql-server    | @polkadot/util-crypto has multiple versions, ensure that there is only one installed.        
orion_graphql-server    | Either remove and explicitly install matching versions or dedupe using your package manager.                                                                                                                         orion_graphql-server    | The following conflicting packages were found:
orion_graphql-server    |       cjs 9.5.1       node_modules/@polkadot/util-crypto/cjs
orion_graphql-server    |       cjs 9.7.2       node_modules/@polkadot/types/node_modules/@polkadot/util-crypto/cjs
...
QueryFailedError: relation "gateway_config" does not exist
...
orion_graphql-server exited with code 2

The orion team could improve documentation and instructions for operators. The increased complexity risks to drive away existing operators and stops anyone interested from trying out atlas (which alone fails).
Some starting points concerning the latest release:

  • the changelog has no instructions how the plethora of new variables have to be used. The documentation has to be improved.
  • local testing instructions should not apply for operators but are the only ones available. The placeholder config is already outdated and incomplete. The listed docker-compose logs -f --tail 10 orion-processor fails because the container is named orion_processor as example.
  • Two containers in the default setup (make up) always fail:

CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
9eae6604498b node:14 "docker-entrypoint.s…" 10 minutes ago Restarting (2) 29 seconds ago orion_processor
2399256c7283 node:14 "docker-entrypoint.s…" 10 minutes ago Restarting (2) 22 seconds ago orion_graphql-server

  • orion2 branch seems no longer supported, the processor fails with driverError: error: relation "bid" already exists. (This failed before.)
  • A typical warning for up and kill commands that should also be addressed is

WARNING: Found orphan containers (orion_auth-api) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.

For a start group the config sections better into email and optional stuff to the bottom. Add comments what settings are available for example regarding db settings. Email variables are now all over the place although not strictly needed. Also gleev is hard-coded a few times, better to keep those together at the topic without empty variables. Those are obvious anyone looking at it with fresh eyes trying to optimize the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants