Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't wrap OperationCanceledException in CsvHelper.WriteRecordsAsync #2277

Open
stjimmy54 opened this issue Aug 2, 2024 · 0 comments
Labels

Comments

@stjimmy54
Copy link

Describe the bug
In Web Api OperationCanceledException usually throws when request was cancelled by user.
Most of apps don't want to have such errors in logs, metricts and etc.
It's hard to identify OperationCanceledException when it throws from CsvHelper.WriteRecordsAsync because we have to check inner exception.
May it be changed? May OperationCanceledException be just re-throwed instead of wrapping it in WriterException?

Expected behavior
throw OperationCanceledException as is.

@stjimmy54 stjimmy54 added the bug label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant