Imagemin Infinite Loop

[donaldG]

If I remove an image from the /assets/images/ directory while gulp watch is running then the imagemin task gets stuck in an infinite loop. Wondering if there just needs to be a separate raw/distro directory for images? I know that creates some duplication but not sure what else is going on with that task. My best guess is the task is modifying the directory, it's also watching the directory for changes, so then it gets stuck: watching, modifying, watching, etc...

[anyway]

Same here... I can confirm the issue.

[garretthyder]

I wonder if this has to do with the fact we're watching the files twice as was noticed in #282 Can you take a look at PR #303 and apply that fix to your gulpfile.js and see if that has any effect. Thanks

[donaldG]

@garrett-eclipse good thought but didn't work. Tried the PR @ #303 with no luck. The only thing I've gotten to work thus far is around line 60 changing, images: 'assets/images/**/*', to images: 'assets/images/src/**/*', and adding that \src\ directory manually.

[garretthyder]

Reading into some articles you're right we'll probably need to separate the source from the destination or we'll always have an infinite loop.

So as you mentioned setting up the /src directory inside assets/images and then having that be the SOURCE on line 60 is the right approach to avoid this.

[garretthyder]

I've put together PR #304 to resolve this issue. Cheers

[garretthyder]

I messed up PR #304 so have replaced with PR #312

[johnw6761]

Has this been resolved, I still have this issue?

[donaldG]

Dunno. I make pizza now, not websites. Thank god. Good luck.

…

On Wed, Apr 4, 2018 at 12:11 johnw6761 ***@***.***> wrote: Has this been resolved, I still have this issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#300 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3AKdi89S_Yn2YvEErwJzSYHqo36rwsks5tlP65gaJpZM4Q-HpQ> .

[JeremyEnglert]

I'll work on getting this merged this weekend.

But @donaldG's comment may be the funniest thing I've read all day.

[garretthyder]

Sorry I've been tied up for a bit, I've merged this into core @johnw6761 please pull the latest and let me know if you have any conflicts, the main change there was migrating images into a segregated src child folder so make sure any custom images are at that level to be optimized.
Closing for now, reopen if you have any issues.
*And @donaldG kudos that split my sides