New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converge my crate into yours #324
Comments
I'm not opposed to adding more derives to this crate. But they should have a utility that's not already provided by the other derives or by normal Rust constructs (or at least provide that utility in a easier to use way). The examples in your crate its README seem already covered:
To be clear it's not to say that these are not useful derives, just that based on the README I don't understand what it is. |
I'm not so sure about that. light_enum provide a way to have a representation of an enum variant.
This is basically the same as EnumIter, but, from my little understanding of Rust, more optimize if you know you will use it in your program, and if your enum will not be very huge (and also if you know you will iter over ALL posible variant of your enum). |
Hi, this is my crate: https://crates.io/crates/light_enum.
Are you interested in a pull request that adds its 2
Derive
keywords (LightEnum
andValues
) ?Values
could be renamed intoArray
.I wrote it without thinking that there were already crate for it. Doing this with the
derive_more
helper functions will be easier I think. And I know there is also EnumDiscriminants from strum.What do you think?
The text was updated successfully, but these errors were encountered: