Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Feature Request: Ability to set list of properties for each object #475

Open
greysondn opened this issue Feb 20, 2019 · 4 comments · May be fixed by #521
Open

Major Feature Request: Ability to set list of properties for each object #475

greysondn opened this issue Feb 20, 2019 · 4 comments · May be fixed by #521
Labels
in review Being reviewed for possible inclusion in master

Comments

@greysondn
Copy link

For example, I'd like to declare that each room has a height, width, and depth. Or that each transition (doorway) has a size limitation. Then the editor would show those as fields I could edit on each room, doorway, and so on.

I'm aware this is not a simple or small feature. I'm not optimistic about it being implemented, or about it being implemented any time soon.

@github-actions
Copy link

Stale issue message

@MidiHax
Copy link

MidiHax commented Feb 22, 2021

I've got a candidate solution for this feature. Will fork and submit a PR.

My implementation is very basic: You can define, at the Map Settings level, a set of "Custom Attributes". These attributes are basically just named strings (ex. "Wall Material", "Water Depth", "Tunnel Collapse Risk", etc). You can specify different sets of Custom Attribute Definitions for Rooms and Connections. The list of Custom Attributes Definitions can also be imported/exported (as plain text files) to make it easier to move your attribute definitions about. The properties dialogs for Rooms and Connections have new tabs that allow you to edit the instance values for the Custom Attributes you've defined. There currently is no validation but that could be added on. Also, all the values are stored as strings but I did include a bit of future proofing if we want to expand to numeric types, etc which could aid validation. I did not update any of the Exporters to include the Custom Attributes but that can also be easily updated for platforms that can utilize them.

MidiHax added a commit to MidiHax/trizbort that referenced this issue Feb 23, 2021
@MidiHax MidiHax linked a pull request Feb 23, 2021 that will close this issue
@ghost
Copy link

ghost commented Feb 23, 2021

I really like this feature. A "geometer" character would be interesting to create in some world-settings. I'm thinking in particular of a character from the classic The Manuscript Found in Saragossa and, in general, of works like Hypnerotomachia Poliphili in which there's a strange fixation on measurements.

@JasonLautzenheiser
Copy link
Owner

I'm beginning to review this feature and the PR that @MidiHax created #521

@JasonLautzenheiser JasonLautzenheiser added in review Being reviewed for possible inclusion in master and removed no-issue-activity labels Nov 9, 2021
@JasonLautzenheiser JasonLautzenheiser linked a pull request Nov 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Being reviewed for possible inclusion in master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants