-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automap: command to recognize a room name #471
Comments
Thanks for the report of this issue. The automapper has been neglected some over the years, at least since I've taken over maintenance, so there is plenty of room for improvements. Thanks for the suggestions! |
One other thing I'm thinking about doing, perhaps as part of a general rewrite of this, is to open up the a lot of options (with smart defaults). There is a lot of code with "magic" rules on what constitutes a room name (capitalization, word length, ...) If I open these up for adjustment by the user, you could make trizbort read a particular map better. This combined with the commands mentioned above would give the user better control and allow Trizbort to learn as it goes. |
Stale issue message |
I was attempting to automap Cragne Manor, but it failed to recognize the names of certain rooms, e.g. "Exterior of Train Station (Emily Short with additions from Graham Nelson)" and "Town square, Backwater, VT (Marco Innocenti)"
Here's the transcript, for the record
Failing to detect room names is understandable; room detection is a hard problem.
But I wish there were a
tb
command I could use, e.g.tb room Exterior of Train Station (Emily Short with additions from Graham Nelson)
which would then signal to the automapper that this is a room name, so it should be added to the map, and tell the automapper that this is my current room, so if I then return north, it could add the relevant two-way connection to the previously detected room.As it currently stands, when the automapper fails to detect a room name, it entirely fails to detect a room transition, so if I try to manually add "Exterior of Train Station" to the automap south of Train Lobby, it doesn't know that I'm currently in that room. When I go south of Exterior, it thinks I'm still in the Train Lobby, and so it thinks Milkweed is also south of Train Lobby, prompting me whether I want to "keep" Exterior, Milkweed or both.
Overall, it's just a lot of fiddly manual effort to fix automap when it fails to detect a room name, and I think just a little bit of transcript hinting would help a lot.
The text was updated successfully, but these errors were encountered: