-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop warning about HOME
not being present on Windows runners
#160
Comments
I can confirm that my company has been using your GHA workflow and we have been seeing this warning for quite some time :) It looks like the HOME env var is not used for anything other than tests. Indeed some time ago explicitly failing on missing env vars was reverted because valid GitHub envs omitted some of the list. It seems like dropping HOME from that list would be safe to do, provided the tests were updated to alter a different expected env var. |
This issue has been inactive for awhile; please comment if it's still relevant! |
Yup |
But I did comment! >:| |
As of now, the toolkit is creating a warning every time the
HOME
env variable is not present, as it's part of the required env variables:actions-toolkit/src/index.ts
Lines 264 to 274 in c6c7208
A user of mine has reported here that Windows runners don't use the
HOME
variable, even if they are original runners from GitHub.I think the
HOME
variable could be removed from the list, since it doesn't seem to be actually used by the toolkit. Also, if one really needed to work with paths, there are a lot of other variables that GitHub provides in their runners, like:GITHUB_WORKSPACE
,GITHUB_ACTION_PATH
,GITHUB_EVENT_PATH
,GITHUB_PATH
, ...The text was updated successfully, but these errors were encountered: