Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ranges): extend lint-semver-ranges to include specifier types #198

Open
JamieMason opened this issue Feb 15, 2024 · 0 comments
Open

Comments

@JamieMason
Copy link
Owner

JamieMason commented Feb 15, 2024

Description

When inspecting semver ranges, syncpack only looks at ^, ~ etc. but it could also ensure that instances in a semver group are all file: or alias dependencies etc.

Use case (microsoft/FluidFramework#19637)

// Testing file: dependencies for build-common across the repo. I wanted to at
// least guarantee that a file: dependency was being used, but syncpack doesn't
// seem to support that without the file path being the same everywhere, which
// doesn't work in our repo.
{
  label: 'build-common should be a file: dependency',
  dependencies: ['@fluidframework/build-common'],
  packages: ['**'],
  isIgnored: true,
}

Suggested Solution

All of the specifierTypes used to target instances could be used in place of the range property as additional allowed values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant