Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double_pianoroll_to_df is very slow. #75

Open
apmcleod opened this issue Oct 18, 2019 · 2 comments
Open

double_pianoroll_to_df is very slow. #75

apmcleod opened this issue Oct 18, 2019 · 2 comments
Labels
speed Performance/speed optimization
Milestone
Later

Comments

@apmcleod
Copy link
Collaborator

Eval on the test set for 1 model I trained ran nearly 30 mins.
@apmcleod apmcleod added the enhancement New feature or request label Oct 18, 2019
@apmcleod apmcleod added this to the Dataset v1.0 Release milestone Oct 18, 2019
@apmcleod apmcleod added speed Performance/speed optimization and removed enhancement New feature or request labels Oct 31, 2019
@apmcleod
Copy link
Collaborator Author

apmcleod commented Nov 1, 2019 •
edited
Loading

Getting the data loaders to return the clean and degraded dfs should cut this time in 1/3.

But this has proven to be difficult:

TypeError: default_collate: batch must contain tensors, numpy arrays, numbers, dicts or lists; found <class 'pandas.core.frame.DataFrame'>

@JamesOwers
Copy link
Owner

This isn't priority for ACME v1.0, kicking to Next milestone (but may want to kick even further if it's a bit tricky).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
speed Performance/speed optimization
Projects
None yet
Milestone
Later
Development

No branches or pull requests
2 participants
@JamesOwers @apmcleod