New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelling improvements #161

Open

JamesOwers opened this issue Oct 8, 2020 · 0 comments

Owner

JamesOwers commented Oct 8, 2020

May have listed these elsewhere too, but noting as I go through docs

we should probably never create pianorolls prior to feeding the data to the model, but rather make clever use of an embedding layer in the model. The difficulty will arise with the treatment of simultaneous notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment