Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

measure_errors doesn't detect any deg parameters #118

Open
apmcleod opened this issue May 13, 2020 · 2 comments
Open

measure_errors doesn't detect any deg parameters #118

apmcleod opened this issue May 13, 2020 · 2 comments
Assignees
@apmcleod
Labels
enhancement New feature or request
Milestone
Later

Comments

@apmcleod
Copy link
Collaborator

If we do fix this, we should also then ensure that the json file it generates loads those parameters. (Currently it doesn't)
@apmcleod apmcleod added the enhancement New feature or request label May 13, 2020
@apmcleod apmcleod self-assigned this Aug 6, 2021
@apmcleod
Copy link
Collaborator Author

apmcleod commented Aug 6, 2021

Will include this in my work on the params branch.

@apmcleod
Copy link
Collaborator Author

I have currently implemented all of the degradation parameters, except for:

  • The various align_* parameters (I don't think these are really useful to learn. It is more of a modeling decision as to whether you want them)
  • split_note__num_splits (I think using the default of 2 is sensible, since more splits can always be modeled by multiple splits).

TODO is writing tests for these #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apmcleod apmcleod

Labels
enhancement New feature or request
Projects
None yet
Milestone
Later
Development

No branches or pull requests
1 participant
@apmcleod