Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download csv files directly from datasets? #105

Open
JamesOwers opened this issue Nov 26, 2019 · 1 comment
Open

download csv files directly from datasets? #105

JamesOwers opened this issue Nov 26, 2019 · 1 comment
Labels
design This pertains to design decisions enhancement New feature or request
Milestone

Comments

@JamesOwers
Copy link
Owner

We could implement a download_csv method in downloaders to handle direct downloading of csvs if they are avail. This is very specific to PPDD though...unless we have other datasets with csvs as opposed to midi I wouldn't bother with this.

@JamesOwers JamesOwers added the enhancement New feature or request label Nov 26, 2019
JamesOwers added a commit that referenced this issue Nov 26, 2019
Issues now written to address later: #98, #99, #100, #101, #102
issues #103 #104 #105 #106 #107 and #108
@apmcleod
Copy link
Collaborator

We have empty versions of these, which we try to download first. It requires the csv to be in exactly the correct format for us (or for the loader to convert into our format on the fly). I'd probably leave it for now, and allow people to implement that for an non-MIDI format (which they'd then have to convert within the download_csv function).

@apmcleod apmcleod added the design This pertains to design decisions label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This pertains to design decisions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants