Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe the HIGH_WATER_MARK idea doesn't make sense?! #134

Open
JackKelly opened this issue May 21, 2024 · 0 comments
Open

Maybe the HIGH_WATER_MARK idea doesn't make sense?! #134

JackKelly opened this issue May 21, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone
0030: Simplify & ...

Comments

@JackKelly
Copy link
Owner

Maybe we should simplify the code, so we just fill the io_uring submission queue until len(sq) + len(cq) - MAX_ENTRIES_PER_ITERATION >= SQ_LEN. Don't bother with the HIGH_WATER_MARK idea. I'm not sure it makes sense?

I should probably benchmark though!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
light-speed-io
Status: Todo
Milestone
0030: Simplify & improve usability & ...
Development

No branches or pull requests
1 participant
@JackKelly