Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to comments editor #12193

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JorECardenas
Copy link

@JorECardenas JorECardenas commented Nov 15, 2024

Add a way to add images in the comments editor by pasting or dragging, still needs work

image

Fix #10559

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@HoussemNasri
Copy link
Member

Please use a better name for the pull request title. Also, change this line Related to issue 10559 to Fix #10559 so that the pull request is linked to the issue and closed automatically once the PR is merged.

@JorECardenas JorECardenas changed the title Fix for issue 10559 Add images to comments editor Nov 19, 2024
@Siedlerchr
Copy link
Member

Looks already cool! Are you planning to continue working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow file attachment into the comments editor (Markdown)
3 participants