-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VScode #12089
Add VScode #12089
Conversation
Fix #11996 |
You have committed submodule changes. Please refer to https://devdocs.jabref.org/code-howtos/faq.html#submodules. |
@subhramit The issue 11996 is closed. But I didn't implement the VScode. One member @Siedlerchr let me to open a new Pr to do this. And I did all the submodule changes, every thing is good. |
You can then refer to continuations using "Follow-up to <PR#>" or "Refs. <Issue#/PR#>".
Please check the changed files on this PR: These are not yet reverted. There has been no commit on this PR after my comment, so it's possible you forgot to push changes. |
|
||
@Override | ||
protected String[] getCommandLine(String keyString) { | ||
// No idea to insert the citation to the open tex file in vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refs #6775
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a seperate PR.
But link the issue in the TODO.
TODO: #6775 |
should I open another pull request to fix issue #6775? or I should push more codes in this issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried.
Changed to "VScode" in the pferences. Did not work.
I needed to manually configure C:\Program Files\Microsoft VS Code\Code.exe
as path.
JabRef should use this path if on Windows as default setting when switching to VScode in the prefernces - and no other value exists in this field.
Sorry. I have a question. Where could I add those default path? I am a little bit confused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out. Works.
Small suggestion to add a link to the other issue. - And also using default keywords to indicate a TODO.
|
||
@Override | ||
protected String[] getCommandLine(String keyString) { | ||
// No idea to insert the citation to the open tex file in vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// No idea to insert the citation to the open tex file in vscode | |
// TODO - Implementing this will fix https://github.com/JabRef/jabref/issues/6775 |
I add the external tex editor program VScode. The double click citation could opent the VScode and jump to the specific line.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)