Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VScode #12089

Merged
merged 11 commits into from
Oct 26, 2024
Merged

Add VScode #12089

merged 11 commits into from
Oct 26, 2024

Conversation

u7465990
Copy link
Contributor

I add the external tex editor program VScode. The double click citation could opent the VScode and jump to the specific line.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@u7465990
Copy link
Contributor Author

Fix #11996

@subhramit
Copy link
Member

You have committed submodule changes. Please refer to https://devdocs.jabref.org/code-howtos/faq.html#submodules.
Also, reference to an issue with keywords (fix, closes) should go to the PR description, else it will not be linked.

@u7465990
Copy link
Contributor Author

@subhramit The issue 11996 is closed. But I didn't implement the VScode. One member @Siedlerchr let me to open a new Pr to do this. And I did all the submodule changes, every thing is good.

@subhramit
Copy link
Member

subhramit commented Oct 26, 2024

@subhramit The issue 11996 is closed. But I didn't implement the VScode. One member @Siedlerchr let me to open a new Pr to do this.

You can then refer to continuations using "Follow-up to <PR#>" or "Refs. <Issue#/PR#>".

And I did all the submodule changes, every thing is good.

Please check the changed files on this PR:
image
image

These are not yet reverted. There has been no commit on this PR after my comment, so it's possible you forgot to push changes.

@u7465990
Copy link
Contributor Author

u7465990 commented Oct 26, 2024

Follow-up to Pr #12044, Refs. Issue#11996


@Override
protected String[] getCommandLine(String keyString) {
// No idea to insert the citation to the open tex file in vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs #6775

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a seperate PR.

But link the issue in the TODO.

@u7465990
Copy link
Contributor Author

TODO: #6775

@u7465990
Copy link
Contributor Author

should I open another pull request to fix issue #6775? or I should push more codes in this issue?

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried.

Changed to "VScode" in the pferences. Did not work.

I needed to manually configure C:\Program Files\Microsoft VS Code\Code.exe as path.

JabRef should use this path if on Windows as default setting when switching to VScode in the prefernces - and no other value exists in this field.

@u7465990
Copy link
Contributor Author

I needed to manually configure C:\Program Files\Microsoft VS Code\Code.exe as path.

JabRef should use this path if on Windows as default setting when switching to VScode in the prefernces - and no other value exists in this field.

Sorry. I have a question. Where could I add those default path? I am a little bit confused

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out. Works.

Small suggestion to add a link to the other issue. - And also using default keywords to indicate a TODO.


@Override
protected String[] getCommandLine(String keyString) {
// No idea to insert the citation to the open tex file in vscode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// No idea to insert the citation to the open tex file in vscode
// TODO - Implementing this will fix https://github.com/JabRef/jabref/issues/6775

@koppor koppor enabled auto-merge October 26, 2024 23:27
@koppor koppor added this pull request to the merge queue Oct 26, 2024
Merged via the queue into JabRef:main with commit 08aa10c Oct 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants