-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GPT4All server api #11870 #12078
Support GPT4All server api #11870 #12078
Conversation
…Chat4AllModel class to send request to the local model and parse the response successfully!
…0' into Support-GPT4All-Server-API-JabRef#11870
src/main/java/org/jabref/logic/ai/chatting/model/Chat4AllModel.java
Outdated
Show resolved
Hide resolved
@NoahXu718 @InAnYan Should be the reviewer here, because he added the AI feature to JabRef. |
Thanks for mentioning, Oliver! |
Nice job, NoahXu718! There are lots of things to do to add a new provider. And it's super cool that you disabled API key for gpt4all. But I'll review the code a little bit later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code comments to enable Ruslan to focus on the content.
src/main/java/org/jabref/gui/ai/components/aichat/AiChatComponent.java
Outdated
Show resolved
Hide resolved
// langchainChatModel = Optional.of(new JvmOpenAiChatLanguageModel(aiPreferences, httpClient)); | ||
// System.out.println("a"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this? Just remove this code.
src/main/java/org/jabref/logic/ai/chatting/model/JvmOpenAiChatLanguageModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/ai/components/privacynotice/PrivacyNoticeComponent.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I left some moments to change.
And yeah, use GPT4All instead of Chat4All
src/main/java/org/jabref/gui/preferences/ai/AiTabViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/ai/chatting/model/JvmOpenAiChatLanguageModel.java
Outdated
Show resolved
Hide resolved
… the JvmOpenAiChatLanguageModel.java to its original state(main).
…g BLANK when the model name is not specified
I think everything has worked well. Could you please check if this pull request can be approved? @InAnYan |
Did you see the comments? #12078 (comment) Please use the "Files" tab to check if the comments are addressed by you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small changes, everything is good!
… and BLANK_GPT4ALL
…0' into Support-GPT4All-Server-API-JabRef#11870
- Add AI preferences section to changelog - Add AI providers to changelog
@NoahXu718 Thank you for your contribution and all the effort! The feature still needs a little work, but we are getting there! :-) |
Closes #11870
Describe the changes you have made here: what, why, ...
What change:
fixed the response cutoff bug, and now the response from the local model should be complete.
Add Gpt4All choice in ai provider, use this option to use the local model.
disable the API key text field when using the local model.
Why:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)