-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting content of other user's comments #11106
Comments
Hi @koppor ,may I ask to contribute for this issue? |
@lllllllittlesun Sure. Please create a minimal JavaFX application (maybe based on https://github.com/Siedlerchr/javafxreproducer) to reproduce the issue. Then, you can check whether an issue needs to be files to JavaFX team or if we did something wrong in JabRef. -- In other words: This issue is more on reproducing than on writing much code. |
@koppor Okay, I'll try this. But May I please be assigned this issue? |
Welcome to the vibrant world of open-source development with JabRef! Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. In case you encounter failing tests during development, please check our developer FAQs! Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 |
Fix issue JabRef#11106, make others comment could be copied.
#12020) * Fix issue #11106, make others comment could be copied. * Update CHANGELOG.md for fix issue #11106 * Modify code formatting * Implement the method "setEditable" in "MarkdownEditor". Adjust the order of the code * Remove duplicate content in CHANGELOG.md --------- Co-authored-by: Christoph <[email protected]>
Is your suggestion for improvement related to a problem? Please describe.
In the Comments panel, when a different user writes a user-specific comment (showing as
Comment-name
) it appears as a disabled textarea to other people reading that entry so it can only be edited by the original author, but it also makes it disabled for selection. That makes is so that if someone adds e.g. a link in their comment, it can't be selected to be copied to the browser.Describe the solution you'd like
It would be nice if text in the user-specific comments could be selected, while maintaining the un-editability of the field.
Additional context
I've had a bit of a look around to see how easy it would be to hack this functionality into the current implementation, but I wasn't able to find the right point in the code (in the javafx library) where the disabled state affects selectability.
I see 3 easy possibilities to implement this:
Of the three, I believe second or third option might be best (and third might be easier to implement, maybe?), since they would also make the text more readable, as the greyed-out text of the default disabled fields is not ideal to read.
The text was updated successfully, but these errors were encountered: