Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Changes Resolver: Discussion on buttons #618

Open
koppor opened this issue Sep 3, 2022 · 1 comment
Open

External Changes Resolver: Discussion on buttons #618

koppor opened this issue Sep 3, 2022 · 1 comment

Comments

@koppor
Copy link
Member

koppor commented Sep 3, 2022

grafik

The buttons "Accept" and "Deny" are located right of the change. Then, there is the button "Close" at the bottom of the panel.

The difference between "Close", "Accept", and "Deny" are unclear. If I press close, the popup asking to review the changes disappears, which also happens if I press "Accept" and "Deny".

It seems that the buttons "Accept" and "Deny" are NOT per change, but for ALL changes.

Therefore, I propose to but the buttons on the lower part of the dialog.

Maybe, the "Close" button can be removed compeletely. If not (because it has a difference to the other buttons), please label it accordingly.

@koppor
Copy link
Member Author

koppor commented Sep 7, 2022

The button is per change, not for everything.

The special behavior is if there is only one change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant