feat!: Implementing OS-specific download buttons #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Partially fixes #2176
📚 Description
This pull request changes the download interface of the website. To detail, the old
Download JabRefbutton is now changes based on the OS of the system (e.g.,Windows,Mac,Linux). Windows should have buttons for.msiand.zip. For Linux,.deb,.rpm, and.tar.gz. For Mac (botharm64andx86_64),.dmgand.pkg. Consequently, changes in the/download/[[os]]path was necessary to implement redirection (expansion from just['win', 'mac', 'linux']This pull request solves a user problem in which the web site automatically downloads a file which might not be apt for their package manager and or system architecture.
Original Implementation for Windows
New Implementation for Windows
New Implementation for Mac
New Implementation for Linux