Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues detected via audits on Chrome #2

Open
aalemayhu opened this issue Jan 31, 2019 · 4 comments
Open

Fix issues detected via audits on Chrome #2

aalemayhu opened this issue Jan 31, 2019 · 4 comments

Comments

@aalemayhu
Copy link
Member

screenshot 2019-01-31 at 12 55 37
@aalemayhu
Copy link
Member Author

Thanks to @jmallberg for mentioning this tool.

@aalemayhu
Copy link
Member Author

Made some changes and the score is now

screenshot 2019-02-02 at 4 35 06 pm

@aalemayhu
Copy link
Member Author

@jmallberg could you help out with the PWA issues? I have no idea what I am doing and would appreciate your help 😄

@aalemayhu aalemayhu mentioned this issue Feb 2, 2019
Closed
aalemayhu added a commit that referenced this issue Feb 2, 2019
@aalemayhu
add manifest file and placeholder favicon
3246b26 
Related-to: #2 (Fix issues detected via audits on Chrome)

Signed-off-by: Alexander Alemayhu <[email protected]>
@aalemayhu GitSpeak
Copy link
Member Author

It looks better now with everything green

image.png

Looks a bit better in incognito mode

image.png

Most issues seem to be related to PWA

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aalemayhu