Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing issue when LineMode = lmBands #1091

Open
beNative opened this issue Mar 8, 2022 · 4 comments
Open

Drawing issue when LineMode = lmBands #1091

beNative opened this issue Mar 8, 2022 · 4 comments
Labels
Bug Low Priority Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR.

Comments

@beNative
Copy link

beNative commented Mar 8, 2022

I added an example project in which the issue can be reproduced. After startup just unfold some nodes and you will see that the bands are not drawn correctly.
afbeelding
VTBug.zip

@joachimmarder
Copy link
Contributor

When I compile your sample with V7.6.x under Delphi 11 the results looks quite OK:
grafik

Which version of Virtual TreeView and Delphi did you use?

joachimmarder added a commit that referenced this issue Mar 13, 2022
Minor improvement for TVTLineMode.lmBands, see #1091
@beNative
Copy link
Author

Hi, I use the trunk version on Delphi 10.4 Community Edition (32bit). It seems to have improved since the last commits you did but I'm still able to get inconsistent drawing when collapsing individual nodes. I will try it tomorrow on D11 to see if it behaves differently.

afbeelding

afbeelding

@beNative
Copy link
Author

On D11 and another PC I was able to reproduce the same issue:

afbeelding

@joachimmarder
Copy link
Contributor

joachimmarder commented Mar 20, 2022

I tested again with the new Delphi 11.1 and the results remained the same. It looks OK, but not perfect here, sometimes lines are missing:
grafik

grafik

Since I adopted the project several years ago, I never came across the setting LineMode lmBands or its code. So I doubt that many people are using it. I will accept pull request for this issue but I don't think it makes sense to invest much time here

@joachimmarder joachimmarder added Bug Low Priority Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR. labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Low Priority Pull Requests Invited There are no current plans to address the issue, but we would be happy if someone supplies a PR.
Projects
None yet
Development

No branches or pull requests

2 participants