Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla visuals are not maintained if a gbuffer pass is omitted #2537

Open
mateuskreuch opened this issue Nov 19, 2024 · 0 comments
Open

Vanilla visuals are not maintained if a gbuffer pass is omitted #2537

mateuskreuch opened this issue Nov 19, 2024 · 0 comments

Comments

@mateuskreuch
Copy link

What happened?

When creating a shader, the vanilla visuals of Minecraft are not maintained if a specific gbuffer pass is omitted. For example, if gbuffers_skybasic is missing, there are no stars at night; if gbuffers_clouds is missing, the fog is not applied correctly to them; if gbuffers_armor_glint is missing, the glint is then not animated; and so on.

This forces shader developers to do more work than necessary if they wish to keep some parts vanilla, especially since in some cases it's not so trivial to cover all edge-cases with a replacement. It also differs from Optifine, which keeps vanilla visuals in this scenario.

Screenshots

Image

Log output

No response

Minecraft Version

1.21.3

Iris Version

iris-fabric-1.8.0+mc1.21.1.jar

Operating System

Windows 10

What is your GPU?

Nvidia GeForce RTX 2060

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant