Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GainNode.gain deprication #89

Open
RomanBurunkov opened this issue Dec 25, 2017 · 9 comments
Open

GainNode.gain deprication #89

RomanBurunkov opened this issue Dec 25, 2017 · 9 comments
Assignees
Labels

Comments

@RomanBurunkov
Copy link

RomanBurunkov commented Dec 25, 2017

Hi there,

In Chrome v. 63.0.3239.108 console

I see the following warning message for ion.sound.min.js: 14:

[Deprecation] GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.

@IonDen
Copy link
Owner

IonDen commented Dec 25, 2017

Hi, Roman. Thanks for update, will fix it.

@IonDen IonDen self-assigned this Dec 25, 2017
@IonDen IonDen added the Request label Dec 25, 2017
@dbusacca
Copy link

Any news on this isuee?

Meanwhile there is a new deprecation note:

[Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018 See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.

@IonDen
Copy link
Owner

IonDen commented Jan 22, 2018

@dbusacca thanks for update. Work in progress now.

@douglaszaltron
Copy link

douglaszaltron commented Jan 30, 2018

line 525 / 628
this.gain.gain.value = this.volume;
change to
this.gain.gain.setTargetAtTime(this.volume, audio.currentTime, 0.015);

I believe is this
@IonDen

@IonDen
Copy link
Owner

IonDen commented Jan 31, 2018

@douglaszaltron, i will check this soon

@RomanBurunkov
Copy link
Author

Hello @IonDen ,

Any updates on this?

Thanks, Roman.

@IonDen
Copy link
Owner

IonDen commented Mar 5, 2018

Hi, finally i found time to work on it. Probably this week update will be released.

@RomanBurunkov
Copy link
Author

Hello @IonDen , have you managed to fix this?

Thanks, Roman.

@IonDen
Copy link
Owner

IonDen commented May 8, 2018

I have a delay now. Sorry guys. Will try release the fix before end of May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants