Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ToFractionString variant #59

Open
jordanrobot opened this issue Dec 26, 2020 · 3 comments
Open

Create ToFractionString variant #59

jordanrobot opened this issue Dec 26, 2020 · 3 comments
Projects
Todo

Comments

@jordanrobot
Copy link
Member

jordanrobot commented Dec 26, 2020 •
edited

  1. User can specify any denominator
  2. rounds to nearest value
  3. make an option to round up or down?
  4. calculates instead of using a lookup.

Syntax:
[New]ToFraction(double value, int roundingAccuracy)
@jordanrobot jordanrobot added this to Future Backlog in Todo Dec 26, 2020
@PockyBum522
Copy link
Contributor

I have code for this. Lemme see if I can find it easily.

@PockyBum522
Copy link
Contributor

Check out:

https://github.com/PockyBum522/InventorShims/commit/a5b74126ec6e365dfc747440d5cd5e7e3f461f7d

@PockyBum522
Copy link
Contributor

Note that the DecimalToFractions is untested. Test well if you implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Todo
Future Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanrobot @PockyBum522