-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed defaultCekParameters*
back up?
#6180
Comments
I was nervous about that code so I left it untouched. Can we try taking out See also #6088, which might need some reorganisation of the tests anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This:
and other such
defaultCekParameters*
definitions are artificially slowed down with thatnoinline
call, so that if we use them anywhere where performance matters, we can spot it right away. But we use this definition a lot in tests and so many our tests are artificially slowed down. This is perhaps a waste of resources. Should we remove thenoinline
call? But then there's no guarantee that we won't get the same slowdown accidentally, since performance of those definitions isn't checked anywhere. And it probably won't even work properly now, because inlining machine parameters for each semantics variant will produce dozens of thousands of lines of code and GHC may simply give up trying to optimize all of that.Or should we "simply" use the production
mkMachineParametersFor
everywhere including tests? That would reliably give us proper performance. The issue is with the "simple" part as that would me a major overhaul of tests. At least we can do it incrementally I suppose.The text was updated successfully, but these errors were encountered: