Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow property test #6069

Closed
Unisay opened this issue May 21, 2024 · 1 comment
Closed

Fix slow property test #6069

Unisay opened this issue May 21, 2024 · 1 comment

Comments

@Unisay
Copy link
Contributor

Unisay commented May 21, 2024

#6062 (comment)

        parser ignores whitespace:                                                    OK (687.93s)
            ✓ propIgnores whitespace passed 50000 tests.
        parser ignores comments:                                                      OK (2314.43s)
            ✓ propIgnores comments passed 50000 tests.

The whitespace parser tests are also fragile: its easy to break them when changing name representations, e.g. ` symbols etc.

@Unisay Unisay self-assigned this May 21, 2024
@github-actions github-actions bot added the status: needs triage GH issues that requires triage label May 21, 2024
@Unisay Unisay removed the status: needs triage GH issues that requires triage label May 21, 2024
@zeme-wana zeme-wana linked a pull request May 21, 2024 that will close this issue
@Unisay Unisay removed their assignment May 30, 2024
@effectfully
Copy link
Contributor

I've fixed those in #6286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants