Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default configuration values #4874

Open
4 tasks
coot opened this issue May 8, 2024 · 0 comments
Open
4 tasks

Default configuration values #4874

coot opened this issue May 8, 2024 · 0 comments
Assignees
@crocodile-dentist
Labels
diffusion Issues / PRs related to diffusion layer

Comments

@coot
Copy link
Contributor

coot commented May 8, 2024

This is a follow-up on #4805:

  • pncProtocolIdleTimeout = 5 :: DiffTime
  • pncTimeWaitTimeout = 60 :: DiffTime
  • defaultDiffusionMode = InitiatorAndResponderMode (currently it's there but a wrong type)
  • defaultP2PMode = True (P2P is a promoted type, so let's use a boolean)

When updating cardano-node, default values are used in two places: the POM module and the tests (eExpectedConfig).
@coot coot added the diffusion Issues / PRs related to diffusion layer label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crocodile-dentist crocodile-dentist

Labels
diffusion Issues / PRs related to diffusion layer
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coot @crocodile-dentist