Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No exception handling for PlotSquared unable to paste schematic #4460

Open
2 tasks done
braceyourself07 opened this issue Jul 27, 2024 · 0 comments
Open
2 tasks done
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Enhancement New feature or request

Comments

@braceyourself07
Copy link

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

There is no error handling or log output when a schematic cannot be pasted in PlotSquared (e.g. using /plot backup or /plot schematic).

In Discord, Pierre referenced these two areas of code:

https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/command/Backup.java#L340

https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/backup/PlayerBackupProfile.java#L203

This causes no error or any other output in console or logs when PlotSquared fails to paste a schematic. I only receive the error message "The backup could not be restored: Failed to paste the schematic."

image

To Reproduce

  1. /plot backup save
  2. /plot backup load 1

Expected behaviour

No backup is restored despite backups being enabled, a backup present in the /plugins/PlotSquared/backups folder, and the schematic otherwise works when manually uploaded. I have not tested but may also affect paste-on-claim.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/18bc3af74e1f4306bcc1acea45ea1820

PlotSquared Version

7.3.8-Premium

Checklist

Anything else?

I am using an older version of FAWE (build 743) because I haven't updated to java 21 yet. Not sure if this is related.

@braceyourself07 braceyourself07 added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Jul 27, 2024
@PierreSchwang PierreSchwang added Bug Something isn't working Approved A project maintainer or developer has reproduced this issue Enhancement New feature or request and removed Requires Testing This is a new issue which needs to be approved before labeled with "bug" labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved A project maintainer or developer has reproduced this issue Bug Something isn't working Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants